Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-3412

Admincentral crashes if app descriptor is invalid

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 5.4
    • 5.4
    • app framework, applauncher
    • None

    Description

      Calls DefinitionProvider.get() too eagerly:

      • first, AppDescriptorRegistry tries to get the descriptor to fire AppRegistryEvent with; but only the app name is used. We can surely live firing the event with the related DefinitionMetadata instead.
      • second, AppLauncherLayoutManagerImpl#getLayoutForCurrentUser() iterates over groups and apps, doesn't check if provider is valid before adding it.

      Side note for future plans:

      • we should most likely remove the AppLauncherLayoutManager altogether and move the "current user layout" logic to the shell app (and spare one useless event "conversion" too).
      • RegistryEvents would probably make sense on the AbstractRegistry level now.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                mgeljic Mikaël Geljić
                mgeljic Mikaël Geljić
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD