-
Bug
-
Resolution: Fixed
-
Major
-
5.3.11
-
-
Yes
-
Empty show more show less
-
Saigon 15, Basel 18
-
3
Just out of the #triggerComplete code:
- when async action completes (drumroll) async, we send the pulse message from system-context (user's context is already gone)
- on 5.3.x *only*, we call messagesManager.sendLocalMessage(msg), which internally calls MgnlContext.getUser()... on sys-ctx
It should be trivial to remember the user, just like we do on master (in DefaultAsyncActionExecutor since the 5.4.1 refactoring), and pass it along.
- Let's confirm this suspicion
- See first raw patch at: https://gist.github.com/mkgl/05e30173624e11e9ee34
I haven't tested it, but yes it does deserve a test-case; might be worth writing it off master's DefaultAsyncActionExecutorTest first, and then backport it into 5.3's AbstractCommandActionTest.
Acceptance criteria
- duplicates
-
MGNLUI-3563 Notify initial user upon completing an asynchronous action
- Closed
- relates to
-
MGNLUI-3510 Clean up async action execution
- Closed
- supersedes
-
MGNLUI-3108 Long running actions sometime do not send announced notification when done
- Closed