Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-3591

CommandActionTriggerListener sends pulse message with SystemContext's user

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.3.11
    • Fix Version/s: 5.3.12
    • Component/s: framework
    • Labels:
    • Patch included:
      Yes
    • Sprint:
      Saigon 15, Basel 18
    • Story Points:
      3

      Description

      Just out of the #triggerComplete code:

      • when async action completes (drumroll) async, we send the pulse message from system-context (user's context is already gone)
      • on 5.3.x *only*, we call messagesManager.sendLocalMessage(msg), which internally calls MgnlContext.getUser()... on sys-ctx

      It should be trivial to remember the user, just like we do on master (in DefaultAsyncActionExecutor since the 5.4.1 refactoring), and pass it along.

      1. Let's confirm this suspicion
      2. See first raw patch at: https://gist.github.com/mkgl/05e30173624e11e9ee34
        I haven't tested it, but yes it does deserve a test-case; might be worth writing it off master's DefaultAsyncActionExecutorTest first, and then backport it into 5.3's AbstractCommandActionTest.

        Checklists

        Acceptance criteria

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                oanh.thai Oanh Thai Hoang
                Reporter:
                mgeljic Mikaël Geljić
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:
                  Date of First Response:

                    Checklists

                    Bug DoR
                    DoD

                      Time Tracking

                      Estimated:
                      Original Estimate - 3d
                      3d
                      Remaining:
                      Time Spent - 2d 3.5h Remaining Estimate - 4.5h
                      4.5h
                      Logged:
                      Time Spent - 2d 3.5h Remaining Estimate - 4.5h
                      2d 3.5h