Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-3822 Prepare UI definition registries to the introduction of the definition decorators feature
  3. MGNLUI-3824

Use I18NParentable interface duck-type check to determine whether a definition is i18n-ized

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Neutral
    • Resolution: Fixed
    • Affects Version/s: 5.4.5
    • Fix Version/s: 5.4.6
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Basel 37

      Description

      In BaseDialogPresenter class in order to avoid applying i18n magic multiple times we used to check if an incoming definition is a proxy (=> it was i18n-framework who's proxied an object).

      However, such an assumption is not necessarily valid, especially since 5.4 (introduction of 'injectable' NamedDefinition interface via proxies) and 5.4.6 - definition decorators use proxies to provide fallbacks.

      A safer way to determine that an object has been i18n-ized is to do an instanceof I18NParentable check.

        Attachments

          Activity

            People

            Assignee:
            apchelintcev Aleksandr Pchelintcev
            Reporter:
            apchelintcev Aleksandr Pchelintcev
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: