-
Story
-
Resolution: Outdated
-
Neutral
-
None
-
None
-
-
Empty show more show less
-
Kromeriz 65, Basel 68
-
5
Note
This solution was not accepted and therefore was reverted (see comment below).
Superseded by https://jira.magnolia-cms.com/browse/MGNLUI-4058
Description
If a dialog does not supply an actions node in its definition, then the Cancel and Save Changes actions should be provided by default.
If a dialog does supply an actions node - then only the actions specified should be provided.
Reason: These same actions are used in most dialogs. It is extra effort for developers to always supply them in dialogs, it is something that they can make mistakes with, and it feels like "boilerplate" that must always be added. Evaluators will have a better impression if these same actions are not specified in every dialog definition.
The part of the definition that should be optional:
actions: commit: class: info.magnolia.ui.admincentral.dialog.action.SaveDialogActionDefinition cancel: class: info.magnolia.ui.admincentral.dialog.action.CancelDialogActionDefinition
- depends upon
-
MGNLUI-4022 Move dialog actions from ui-admincentral to ui-dialog module
- Closed
-
MAGNOLIA-6790 Implement changing all properties with certain value also under specified node path
- Closed
- is superseded by
-
MGNLUI-4058 Dialogs have Cancel and Save actions when no actions are specified
- Closed
- supersedes
-
MAGNOLIA-6456 Dialogs should have a default actions configuration
- Closed
- mentioned in
-
Page Loading...