Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-3883

Dialogs have Cancel and Save Changes actions by default

    XMLWordPrintable

Details

    • Story
    • Resolution: Outdated
    • Neutral
    • 5.5
    • None
    • None
    • Kromeriz 65, Basel 68
    • 5

    Description

      Note

      This solution was not accepted and therefore was reverted (see comment below).
      Superseded by https://jira.magnolia-cms.com/browse/MGNLUI-4058

      Description

      If a dialog does not supply an actions node in its definition, then the Cancel and Save Changes actions should be provided by default.
      If a dialog does supply an actions node - then only the actions specified should be provided.

      Reason: These same actions are used in most dialogs. It is extra effort for developers to always supply them in dialogs, it is something that they can make mistakes with, and it feels like "boilerplate" that must always be added. Evaluators will have a better impression if these same actions are not specified in every dialog definition.

      The part of the definition that should be optional:

      actions:
        commit:
          class: info.magnolia.ui.admincentral.dialog.action.SaveDialogActionDefinition
        cancel:
          class: info.magnolia.ui.admincentral.dialog.action.CancelDialogActionDefinition
      

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                pmundt Philip Mundt
                czimmermann Christopher Zimmermann
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoD