Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-3959

Incorrect fieldTypes bootstraps since 5.4.4

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 5.4.8, 5.5
    • 5.4.4
    • framework
    • Saigon 54
    • 3

    Description

      As part of MGNLUI-2496/MGNLUI-3707 (new JCR browser), a new NodeTypeField definition/factory mapping was added.
      However the whole fieldTypes were seemingly re-exported, with extra stuff bootstrapped by other modules in there:

      • RichTextFieldDefinition is mistakenly mapped to the dam's AssetsEnabledRichTextFieldFactory. That one is reconfigured upon dam install, so without dam, rich-text field currently doesn't work.
      • formStaticField (info.magnolia.module.form.fields.definition.StaticFormFieldDefinition) has nothing to do here; form module should also bootstrap this field in its own module instead (follow-up).
      • workbenchField is redundant with a sibling bootstrap file. We should get rid of one.

      I provide the reverted bootstrap: but now we also need an MVH task (delta for 5.4.8). If dam or form modules are not installed, then we need to fix configuration.

      See https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/pull-requests/40/commits/a433396faf0f2b47987d92732cefb71e74f41a65#magnolia-ui-framework/src/main/resources/mgnl-bootstrap/ui-framework/config.modules.ui-framework.fieldTypes.xml

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                hieu.nguyen Hieu Nguyen Duc
                mgeljic Mikaël Geljić
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - 3d
                      3d
                      Remaining:
                      Time Spent - 2d 2.5h Remaining Estimate - 5.5h
                      5.5h
                      Logged:
                      Time Spent - 2d 2.5h Remaining Estimate - 5.5h
                      2d 2.5h