Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-4058

Dialogs have Cancel and Save actions when no actions are specified

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Neutral Neutral
    • 6.1
    • None
    • None
    • None
    • Yes
    • Yes

      If a template dialog does not supply an actions node in its definition, then the Cancel and Save Changes actions should be provided by default.
      If a dialog does supply an actions node - then only the actions specified should be provided.

      Reason: These same actions are used in most dialogs. It is extra effort for developers to always supply them in dialogs, it is something that they can make mistakes with, and it feels like "boilerplate" that must always be added. Evaluators will have a better impression if these same actions are not specified in every dialog definition.

      The part of the definition that should be optional:

      actions:
        commit:
          class: info.magnolia.ui.admincentral.dialog.action.SaveDialogActionDefinition
        cancel:
          class: info.magnolia.ui.admincentral.dialog.action.CancelDialogActionDefinition
      

      A dev should not have to supply a specific class - this should work with the existing Dialog class.

      Validation: https://wiki.magnolia-cms.com/display/PMTEAM/Simplified+Dialogs+LDV

        Acceptance criteria

              Unassigned Unassigned
              czimmermann Christopher Zimmermann
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Task DoD