Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-408

Refactor ActionbarPresenter for better testability

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Major
    • 5.0
    • 5.0
    • None
    • None

    Description

      Current implementation of ActionbarPresenter doesn't allow Unit-Test for many methods and makes it very complicated for others (u have to provided a full ActionbarDefinition although this is only used to instantiated ActionbarViews).

      First step to fix this issue: don't create ActionbarView (via calling ActionbarBuilder.build(definition)) in #start(ActionbarDefinition, ActionFactory) but pass it as a third parameter in the #start method

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                apchelintcev Aleksandr Pchelintcev
                dlipp Daniel Lipp
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoR