-
Bug
-
Resolution: Fixed
-
Neutral
-
5.4.9, 5.5
-
None
-
-
Empty show more show less
-
Kromeriz 84
-
8
Thanks to sfroger in SUPPORT-6874, currently when user set field's config 'readOnly' to 'true', our 'defaultValue' is no longer used when populating its value. This issue leads to no value saved into their JCR persistent.
Expected result: Separate logic of 'defaultValue' and 'readOnly' in fields which means:
1. When a field is readOnly, make it read only from editors.
2. When user set its 'defaultValue', put that value to field's value.
Grep code:
info.magnolia.ui.form.field.factory.AbstractFieldFactory.setPropertyDataSourceDefaultValue(Property) { ... if (defaultValue != null && !definition.isReadOnly()) { .... property.setValue(defaultValue); } }
Solution:
Keep Transformer unaware of definition #readOnly state, only mirror that of the underlying data-source
- Let FieldFactory set defaultValue even if definition is readOnly, but not if underlying property is
- Keep setting field as read-only based on the definition, only at the end of the chain in #setConstraints
- Document Transformer#isReadOnly with intent, and deprecate setter
- In particular, Transformer must not affect the underlying property's read-only state
- Add test from Evzen
- De-abstract BasicTransformer property instantiation for initial value vs. cross-type override (while retaining read-only state);
- Apply lessons learned from BasicTransformer to FileTransformer
- is causing
-
MGNLUI-4155 Cannot add new an asset in DAM application
- Closed
-
MGNLUI-4193 Conflict between jcrName and setNodeName()
- Closed
-
MGNLUI-4368 readOnly property is not working for LinkFields, PasswordFields
- Closed
- relates to
-
MGNLUI-3489 Support field default value for localized properties in all the field types
- Closed
-
MGNLUI-4181 Checkbox field is editable even if 'readOnly' is set to 'true'
- Closed