Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-4249

When populating UI component bindings the algorithm should not bail out on unresolved apps/sub-apps

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Neutral
    • Resolution: Fixed
    • Affects Version/s: 5.5.5
    • Fix Version/s: 5.5.6, 5.6
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Basel 106, Basel 107
    • Story Points:
      2
    • Magnolia Release:
      5.5.6, 5.6

      Description

      When parsing/populating the app and sub-app components we are trying to match the component group id against some registered app.

      For example:

      <components>
        <id>app-foo</id>
        ....
      

      Would match against app foo (if it is present in the app descriptor registry).
      Whereas:

      <components>
        <id>app-foo-bar</id>
        ....
      

      Would match against the sub-app bar of app foo.

      Currently, if app is not present in the registry (i.e. there's no such app foo in the app descriptor registry), the collector of the components will bail and cause the whole IoC preparation process to halt, which something that we should clearly avoid.

      The attached PR prevents an exception from being thrown, rather logs the warning that components mapped to an non-registered app and carries on with bindings population.

        Attachments

          Activity

            People

            • Assignee:
              apchelintcev Aleksandr Pchelintcev
              Reporter:
              apchelintcev Aleksandr Pchelintcev
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: