Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-4275

Default sub-app's component bindings should be exposed to content app choose dialog component provider

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Neutral
    • Resolution: Fixed
    • Affects Version/s: 5.5.5
    • Fix Version/s: 5.5.6, 5.6
    • Component/s: None
    • Labels:
      None
    • Sprint:
      Basel 110, Basel 111
    • Story Points:
      3
    • Magnolia Release:
      5.5.6, 5.6

      Description

      When the default choose dialog definition is provided by the ContentApp class, a large portion of the default sub-app's configuration (browser typically) is applied to it. However, we do not make the choose dialog component provider aware of that sub-apps bindings: the "parent" component provider passed to choose dialog presenter is the one of the app, and only its UI context is considered.

      Luckily enough, that does not cause troubles in the default case (like EE webapp without extra mods), since the current IoC mechanism arranges the bindings so that they are easily accessible without extra context required as long as there's no ambiguity (e.g. several context-specific implementations of the same interface).

      So it happens that e.g. the commerce tools integration brings in the alternative implementation of e.g. TreeView which already prevents any choose dialog from starting!

      In order to fix the problem we need to expose the default sub-app bindings to the choose dialog component provider. Thanks to the new light-weight component providers, that should be not hard at all.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                apchelintcev Aleksandr Pchelintcev
                Reporter:
                apchelintcev Aleksandr Pchelintcev
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: