Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-4367

Crop tool has javascript errors

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • 5.6.1
    • None
    • None

    Description

      The commit, which fixes MGNLUI-4310 introduced a new bug.

      Instead of

       
      this.isEnabled = function() { 
        return getState().enabled !== false 
      }
      

      it should read:

       
      this.isEnabled = function() { 
        return **this**.getState().enabled !== false
      }
      

      Furthermore, I believe, there is one additional bug:
      The commit changed line 51
      from

       
              if (!jcrop || !state.isValid) {
      

      to

       
              if (!jcrop || !this.isEnabled()) {
      

      I believe this should be reverted.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              pgaschuetz Philipp Gaschuetz
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Checklists

                  Bug DoR
                  Task DoD