Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-4525

Wrong logic for customized fieldTypes warning during 5.7 upgrade

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 5.7.1
    • None
    • framework
    • None
    • Saigon 150
    • 1

      Upon upgrading to 5.7, fieldTypes are removed from JCR config and replaced by YAML ones.

      There is supposedly a warning if either definitionClass or factoryClass is different from our expected default mappings (i.e. if it was customized).

      Well... currently the logs and install screen are filled with false positives, because the conditions logic is inverted (see info.magnolia.ui.framework.setup.RemoveFieldTypeDefinitionsFromJcrTask:96), and consequently the actual warnings for such valid customization cases are missing.

      Also visible at:

      2018-07-10 11:04:42,469 WARN  info.magnolia.module.InstallContextImpl           : [0/6 tasks - Magnolia UI Framework (version 5.7.1-SNAPSHOT)]> Field type definition class is different from default one. Expected: [info.magnolia.ui.form.field.definition.BasicUploadFieldDefinition], got: [info.magnolia.ui.form.field.definition.BasicUploadFieldDefinition] in [basicUpload].
      2018-07-10 11:04:42,470 WARN  info.magnolia.module.InstallContextImpl           : [0/6 tasks - Magnolia UI Framework (version 5.7.1-SNAPSHOT)]> Field type factory class is different from default one. Expected: [info.magnolia.ui.form.field.factory.BasicUploadFieldFactory], got: [info.magnolia.ui.form.field.factory.BasicUploadFieldFactory] in [basicUpload].
      2018-07-10 11:04:42,471 WARN  info.magnolia.module.InstallContextImpl           : [0/6 tasks - Magnolia UI Framework (version 5.7.1-SNAPSHOT)]> Field type definition class is different from default one. Expected: [info.magnolia.ui.form.field.definition.CodeFieldDefinition], got: [info.magnolia.ui.form.field.definition.CodeFieldDefinition] in [code].
      2018-07-10 11:04:42,471 WARN  info.magnolia.module.InstallContextImpl           : [0/6 tasks - Magnolia UI Framework (version 5.7.1-SNAPSHOT)]> Field type factory class is different from default one. Expected: [info.magnolia.ui.form.field.factory.CodeFieldFactory], got: [info.magnolia.ui.form.field.factory.CodeFieldFactory] in [code].
      2018-07-10 11:04:42,473 WARN  info.magnolia.module.InstallContextImpl           : [0/6 tasks - Magnolia UI Framework (version 5.7.1-SNAPSHOT)]> Field type definition class is different from default one. Expected: [info.magnolia.ui.form.field.definition.DateFieldDefinition], got: [info.magnolia.ui.form.field.definition.DateFieldDefinition] in [date].
      ...
      

        Acceptance criteria

              mgeljic Mikaël Geljić
              mgeljic Mikaël Geljić
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Bug DoR
                  Task DoD

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0d
                    0d
                    Logged:
                    Time Spent - 7h
                    7h