Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-4548

Zip upload - temp folder not cleared

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Neutral
    • 5.7.2, 6.0
    • None
    • None
    • None
    • Saigon 158
    • 1

    Description

      We had the following UseCase, which leads to huge temp folder content, which is not cleared

      • Uploading a zip file in the assets app
      • Will save the zip file in a temp folder (and not delete it)
      • The used temp folder is the one configured on system (e.g. tomcat) level
        • java.IO.File.createTempFile(...)
          in info.magnolia.ui.framework.command.ImportZipCommand.java:101 
      • The cleanup job should clear the temp folder
        • But it is working on a different configuration, it uses the Magnolia-Webapp temp folder
        • (magnolia.properties -> key: magnolia.upload.tmpdir)
          info.magnolia.cms.core.FileSystemHelper.java:75
          at info.magnolia.cms.core.Path.java:99
          at info.magnolia.ui.framework.command.CleanTempFilesCommand.java:68 
      • Thus these 2 processes not operating on the same temp folder, by heavy using the zip upload, the temp folder will grow
        • This should  not be the case. Probably it would be best if also the ZipUpload would use the Magnolia temp folder (defined by magnolia.upload.tmpdir)

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                mgeljic Mikaël Geljić
                szach Siegried Zach
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - 0d
                      0d
                      Logged:
                      Time Spent - 3h
                      3h