Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-4658

Reenable two bypassed unit tests

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Neutral
    • None
    • None
    • None
    • None

    Description

      MGNLUI-4614 had us come up with a quick fix to allow compatibility Magnolia to use old implementations for components such as dialogs, see: https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/commits/ed020c7fb1cfd1c43da9bde924a41e1c89cd506c

      However, this was at the expense of two tests, which started to fail and were ignored because they couldn't be investigated: https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/commits/85d5b488b425676cc83bc93acde24204f33a10d0

      The problem has been pinpointed to lost weak references. The fix starts by making UI and VaadinSession class fields.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              apchelintcev Aleksandr Pchelintcev
              mmichel Maxime Michel
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Task DoR