Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-5215

DOC: Dialogs have 'commit' and 'cancel' actions by default

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • Neutral
    • None
    • None
    • None

    Description

      User stories

      If a template dialog does not supply an actions node in its definition, then the commit and cancel actions should be provided by default. If a dialog does supply an actions node, then only the actions specified should be provided.

      Rationale: These same actions are used in most dialogs. It is extra effort for developers to always supply them in dialogs, it is something that they can make mistakes with, and it feels like 'boilerplate' that must always be added. Evaluators will have a better impression if these same actions are not specified in every dialog definition.

      This part of the definition should be optional:

      actions:
        commit:
          class: info.magnolia.ui.admincentral.dialog.action.SaveDialogActionDefinition
        cancel:
          class: info.magnolia.ui.admincentral.dialog.action.CancelDialogActionDefinition
      

      A dev should not have to supply a specific class; this should work with the existing Dialog class.

      Task

      Create a new Dialog definition page for Magnolia 6 UI to reflect the recent changes. The old Dialog definition page for Magnolia 5 UI should serve as an inspiration for the new pages.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                akhamis Ashraf Khamis
                akhamis Ashraf Khamis
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoR