-
Improvement
-
Resolution: Won't Fix
-
Neutral
-
None
-
None
-
None
-
-
Empty show more show less
-
Yes
-
later
Right now, we have the following content app implementations that use data source definition where we appear to switch between the singular and plural forms of the data source names across fully qualified class names, component section IDs and component implementations:
Notification data source
- <id>datasource-notifications</id>
- <implementation>info.magnolia.admincentral.apps.notifications.*Notification*PropertySetFactory</implementation>
- <implementation>info.magnolia.admincentral.apps.notifications.*Notification*ItemResolver</implementation>
- <implementation>info.magnolia.admincentral.apps.notifications.*Notification*StatusBar</implementation>
- <implementation>info.magnolia.admincentral.apps.notifications.*Notification*ListPresenter</implementation>
- info.magnolia.admincentral.apps.notifications.*Notification*DataSourceDefinition
Tasks data source
- <id>datasource-tasks</id>
- <implementation>info.magnolia.task.app.*Tasks*PropertySetFactory</implementation>
- <implementation>info.magnolia.task.app.*Tasks*ItemResolver</implementation>
- <implementation>info.magnolia.task.app.*Tasks*StatusBar</implementation>
- <implementation>info.magnolia.task.app.*Task*ListPresenter</implementation>
- info.magnolia.task.app.*Tasks*DataSourceDefinition
Definitions data source
- <id>datasource-definitions</id>
- <implementation>info.magnolia.definitions.app.data.*Definition*ItemResolver</implementation>
- <implementation>info.magnolia.definitions.app.data.*Definition*StatusBar</implementation>
- <implementation>info.magnolia.definitions.app.overview.tree.*Definitions*TreePresenter</implementation>
Possible solution:
To achieve consistency, we either pluralize them all (Notifications, Tasks and Definitions) to bring them in line with their app names (Notifications app, Tasks app and Definitions app) or we singularize them all (Notification, Task and Definition) to bring them in line with other data source names (option list data source, enum data source, JCR data source and registry data source).
Acceptance criteria