Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-5306

Untie details sub-app implementation from the dialogs (notation- style- and impl- wise)

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Neutral
    • None
    • None
    • None
    • None

    Description

      Currently for implementation simplicity ContentDetailsuSubApp is implemented by means of DialogHelper utility which effectively binds the sub-app with how dialogs act and look. Under the hood the DialogComponent instance is used in order to display the sub-app.

      This results into pain of styling the sub-app differently from the dialogs (and complicates the linked ticket finalisation).

      We need to:

      • not use the DialogHelper at least in ContentDetailSubApp. Ideally - phase out the utility completely, because we already have a DialogBuilder.
      • Re-use the relevant parts in CDS that used to be managed by the helper, but compose them differently, use the appropriate style names etc.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                apchelintcev Aleksandr Pchelintcev
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoR