Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-5575

Inline edit feature is incompatible with default action set

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Low
    • None
    • None
    • None
    • None

    Description

      This has already been documented in the past here https://documentation.magnolia-cms.com/display/DOCS62/Content+view+definition+-+6+UI 

       You cannot define a default action and use inline editing at the same time.

      Currently, when both are enabled, they work together, but clash. 

      • If nothing is selected, ENTER triggers inline edit and another ENTER saves changes.
      • If a single item is selected, ENTER triggers inline edit and immediately triggers default action.
      • If a single item is selected and inline editor is open (e.g. via "e" shortcut), pressing ENTER saves inline edit changes and immediately opens currently selected item.

      Development notes

      The main problem is that ENTER opens inline editor eagerly on client side, before server shortcut listeners on ENTER can do anything.

      Since ENTER is not supposed to be the shortcut for inline editing (it is supposed to be "e") a shortcut listener on "e" could check if inline editor was triggered with "e" instead of enter and modify behavior of ENTER depending on this. This was initially experimented with, but it broke some functionality. More experimentation would need to take place or client side changes introduced. Client side changes could also address other issues as well (e.g. MGNLUI-5565)

       

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              sdemocko Šimon Demočko
              sdemocko Šimon Demočko
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Checklists

                  Task DoD