Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-5656

Improve Upload Field implementation

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Neutral
    • 6.2
    • None
    • None
    • None
    • Yes
    • UI Framework 16, UI Framework 17
    • 5

    Description

      Current solution involves composite field based solution and requires the presence of redundant static fields for dimensions (width and height) and file name. Those are quirky implementation-wise and also are buggy.

      The following improvements should be made to the Upload Field implementation:

      • Attach all metadata information that is part of a File to the UploadField (removing the need for redundant static fields).
      • Add required property and validation to UploadField
      • Enable adding custom factoryClass for the UploadField to maintain flexibility in adding new features to the UploadField (DamUploadField in Assets app).
      • Remove redundant static fields from Assets app (and update the app descriptor for the improved UploadField)¬†
      • Extract ValueBoundProperty interface from¬†info.magnolia.ui.field.FieldDefinition, which enables adding a Value based property trait to both simple FieldDefinition (which always have a value) or a info.magnolia.ui.editor.ComplexPropertyDefinition (which may or may not have a Value trait).

      Checklists

        Acceptance criteria

        Attachments

          1. damupload-field-existing-asset.png
            370 kB
            Rishab Dhar
          2. save-empty-media-field.png
            43 kB
            Rishab Dhar
          3. upload-new-asset-updates-media-field.png
            354 kB
            Rishab Dhar

          Issue Links

            Activity

              People

                rdhar Rishab Dhar
                rdhar Rishab Dhar
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoR

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Time Spent - 5m Remaining Estimate - 0.25d
                      0.25d
                      Logged:
                      Time Spent - 5m Remaining Estimate - 0.25d
                      5m