Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-5772

Streamline/revisit implementations of I18nAuthoringSupport

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 6.2.18, 6.3.0
    • 6.2
    • None
    • Yes
    • Nucleus 3, Nucleus 5, Nucleus 7
    • 2

      See slack thread for a little bit of backstory.

      The main concerns we should revisit here include:

      • non-consistent behaviour of the default I18NauthoringSupport (returns a default locale, but without a site configured - returns empty list of available locales, not including the default one).
      • NPE-prone behaviour of the multi-site implementation: in case related site is not resolved for the passed item/node, null is returned for both default locale and available locale list calls.
      • cumbersome #deriveLocalisedName API: for instance always requires to do isDefaultLocale check before (could be done internally in the #deriveLocalisedName).
      • no argument-less API (when we want to access the default i18n confiuration, without any reference item).

      To be compatibility module agnostic:

      • create a new default impl in ui-framework
      • create new JCR impl in ui-framework-jcr
      • keep the current impl in compatibility module (might extend the default/JCR impl)

      https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/magnolia-ui-framework-compatibility/src/main/java/info/magnolia/ui/framework/i18n/DefaultI18NAuthoringSupport.java#69

        Acceptance criteria

              asiska Adam Siska
              apchelintcev Aleksandr Pchelintcev
              Nucleus
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Task DoD

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - Not Specified
                    Not Specified
                    Logged:
                    Time Spent - 0.25d
                    0.25d