Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-5925

Improve API for adding actions to dialog footers

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Neutral
    • None
    • None
    • None

    Description

      Depends on: MGNLUI-5924. Once it sets clear expectations API should be addressed to reflect this, cause it mixes multiple semantics and does not allow for easy adding of predictably styled buttons. 

      Acceptance criteria: 

      • Close/Cancel could use more built-ins, shouldn't need to be declared as an "action". The one opening the Dialog (say via DialogBuilder) should know if anything has to be done upon closing (via #withCloseListener). (from this comment)
      • ActionButton should be made agnostic of button styling (will likely be handled sooner w/ MGNLUI-5951)
      • EditorDialogLayout API should be simplified. Just add action. Primary and secondary slot (left buttons, right buttons) is confusing - mixes with semantics of primary-button and secondary-button which are styles currently applied to committing (primary, green) and everything else. Also there is another style in Resurface theme: "primary" and "secondary", which appears to overlap semantically w/ primary-button, secondary-button.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                sdemocko Šimon Demočko
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:

                  Checklists

                    Task DoD