Details
-
Improvement
-
Resolution: Unresolved
-
Neutral
-
None
-
None
-
None
Description
Depends on: MGNLUI-5924. Once it sets clear expectations API should be addressed to reflect this, cause it mixes multiple semantics and does not allow for easy adding of predictably styled buttons.
Acceptance criteria:
- Close/Cancel could use more built-ins, shouldn't need to be declared as an "action". The one opening the Dialog (say via DialogBuilder) should know if anything has to be done upon closing (via #withCloseListener). (from this comment)
- ActionButton should be made agnostic of button styling (will likely be handled sooner w/ MGNLUI-5951)
- EditorDialogLayout API should be simplified. Just add action. Primary and secondary slot (left buttons, right buttons) is confusing - mixes with semantics of primary-button and secondary-button which are styles currently applied to committing (primary, green) and everything else. Also there is another style in Resurface theme: "primary" and "secondary", which appears to overlap semantically w/ primary-button, secondary-button.
- The usage of DefaultEditorActionLayoutDefinition forces code duplication on extension, see https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/pull-requests/1466/overview?commentId=61979 try to improve that.
- Clean up styles so as not to include and mix secondary, secondary-actions and secondary-button etc.
- Consider CloseActionDefinition not to be "cancel" cause that is quite confusing. Having a non-cancelling action (CommitAD) extend a Cancel action is unintuitive
Checklists
Acceptance criteria
Attachments
Issue Links
- depends upon
-
MGNLUI-5924 Clarify guidelines for styling of dialog footer (and its action buttons)
-
- Closed
-
- relates to
-
MGNLUI-5951 Restrict green button styling in editor footer layout for the rightest element in primary slot
-
- Open
-