Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-5941

Extract VaadinLookup into production code

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Won't Do
    • Neutral
    • None
    • None
    • None
    • None

    Description

      VaadinLookup is a test utility to search for components in hierarchy. 
      There are similar needs in the production code as well:

      The class will need some cleaning up, before it's moved. There's logic that is fairly duplicit 

      • info.magnolia.ui.VaadinLookup#find
      • info.magnolia.ui.VaadinLookup#findComponents(com.vaadin.ui.Component, java.util.function.Predicate<com.vaadin.ui.Component>, java.util.Set<T>)

      but there are differences. Some of the methods and their overloaders only pick the first found component, other pick first and if there's more they throw exceptions, or they return a set. What options to offer needs to be considered and duplicities removed.

      A related class to VaadinLookup that should be extracted with it in some neat package is MultiValueProperty and more might be coming. Think of good packaging and placement for the whole group.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              rkovarik Roman Kovařík
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Task DoD

                  Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - Not Specified
                    Not Specified
                    Logged:
                    Time Spent - 4m
                    4m