Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-6122

Dialog: Label of the form is ignored for the dialog

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Not an issue
    • Affects Version/s: 6.2.2
    • Fix Version/s: None
    • Component/s: dialogs, forms
    • Labels:
      None

      Description

      Situation:

      Problem:

      The label property is ignored, the dialog opens with an i18n key:

      Using this code:

      form:
        label: Two Columns
        properties:
      
      
          titleLeft:
            $type: textField
            label: Left Column Title
            description: Enter title of the left column.
      
      
          titleRight:
            $type: textField
            label: Right Column Title
            description: Enter title of the right column.
      

      Because the Bean does not contain a label property:
      info.magnolia.ui.editor.ConfiguredFormDefinition<T>

      Here the bean-minor-problem report form defintion app:

      Bad side-effect:

      If you create a 'textImage' or a 'teaser' component, the dialog has a Title -> it inherits it form the MTK's i18n message bundle.
      This is very confusing, as one thinks it uses the label, until you try to change it. Or create another dialog and then you have suddenly a key and not the label in use.

      The bad thing besides the confusion of this is, that one does not see the i18n key the system expects.

      Severity of issue:

      This is really bad as one can not create a dialog and set a label, one MUST generate i18n files even when using only one language.

      Imagine a beginner starting to work with magnolia, but not knowing anything yet about the i18n system.

      Or when migrating form old to new dialogs (as it was the case in my training material), soddenly no label is used anymore.

        Checklists

        Acceptance criteria

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                Unassigned Unassigned
                Reporter:
                cringele Christian Ringele
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:
                  Date of First Response:

                    Checklists

                    Bug DoR
                    DoD