Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-691

Extract workbench to a separate module

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Neutral
    • 5.0
    • None
    • None

    Description

      New module name: magnolia-ui-workbench
      Package name: info.magnolia.ui.workbench

      Should include the following classes/packages:

      • info.magnolia.ui.admincentral.content.view.ContentView
      • info.magnolia.ui.admincentral.content.view.builder
      • info.magnolia.ui.admincentral.event.ItemEditedEvent
      • info.magnolia.ui.admincentral.event.ItemSelectedEvent
      • info.magnolia.ui.admincentral.event.ViewTypeChangedEvent
      • info.magnolia.ui.admincentral.event.ItemDoubleClickedEvent
      • info.magnolia.ui.vaadin.integration.jcr.container
      • info.magnolia.ui.admincentral.column
      • info.magnolia.ui.admincentral.list.view
      • info.magnolia.ui.admincentral.list.container
      • info.magnolia.ui.admincentral.search.view
      • info.magnolia.ui.admincentral.search.container
      • info.magnolia.ui.admincentral.thumbnail.view
      • info.magnolia.ui.admincentral.tree.container
      • info.magnolia.ui.admincentral.tree.view
      • info.magnolia.ui.model.column
      • info.magnolia.ui.model.workbench

      Classes in package info.magnolia.ui.admincentral.tree.action should not be moved, this will be handled in MGNLUI-695

      Also check wether these are necessary, appears to be abandoned:

      • info.magnolia.ui.admincentral.content.view.builder.ContentViewBuilderProvider
      • info.magnolia.ui.admincentral.content.view.builder.ContentViewBuilderProviderImpl

      Proposed package structure in the new module:

      • info.magnolia.ui.workbench.event
      • info.magnolia.ui.workbench.definition
      • info.magnolia.ui.workbench.definition.column
      • info.magnolia.ui.workbench.column
      • info.magnolia.ui.workbench.view
      • info.magnolia.ui.workbench.container

      An alternative would be to keep the separation of tree, list, search and thumbnail, as is done today. In this case we should make sure that ThumbnailContainer is in thumbnail.container not in thumbnail.view as it incorrectly is today.

      • info.magnolia.ui.workbench.event
      • info.magnolia.ui.workbench.definition
      • info.magnolia.ui.workbench.definition.column
      • info.magnolia.ui.workbench.column
      • info.magnolia.ui.workbench.tree.view
      • info.magnolia.ui.workbench.tree.container
      • info.magnolia.ui.workbench.list.view
      • info.magnolia.ui.workbench.list.container
      • info.magnolia.ui.workbench.search.view
      • info.magnolia.ui.workbench.search.container
      • info.magnolia.ui.workbench.thumbnail.view
      • info.magnolia.ui.workbench.thumbnail.container

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                dlipp Daniel Lipp
                tmattsson Tobias Mattsson
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoR