Details
-
Improvement
-
Resolution: Unresolved
-
Neutral
-
None
-
None
-
None
-
None
Description
Redundant operations
Some operations doesn't have to be execute when computing the data provider size:
- Wrapping items with node decorator
- streaming (unless filtering publication status) in favour of NodeIterator#getSize()
- see https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/magnolia-ui-framework-jcr/src/main/java/info/magnolia/ui/contentapp/JcrDataProvider.java?at=refs%2Ftags%2Fmagnolia-ui-6.2.27#90
- Order might not be called when getting size https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/magnolia-ui-framework-jcr/src/main/java/info/magnolia/ui/contentapp/JcrDataProvider.java?at=refs%2Ftags%2Fmagnolia-ui-6.2.27#84
Making sure this works in tree view
Fetch would be still called when filtering in tree view. This code should be adjusted as well https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/magnolia-ui-framework/src/main/java/info/magnolia/ui/contentapp/FilterableHierarchicalDataProvider.java#110
Development notes
Original fix was reverted due to ABTEST-539. https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/pull-requests/2288/overview.
Checklists
Acceptance criteria
Attachments
Issue Links
- depends upon
-
ABTEST-539 VariantJcrDataProvider relies on implementation of JcrDataProvider#size
-
- Open
-
1.
|
Implementation |
|
To Do | Unassigned |
2.
|
Review |
|
To Do | Unassigned |
3.
|
Pre-Integration QA |
|
To Do | Unassigned |
4.
|
QA |
|
To Do | Unassigned |