Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-787

Get rid of SASS compilation warnings in the console

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Fix
    • Major
    • 5.0.1
    • 5.0
    • None

    Description

      Currently SASS compilation is processed on-the-fly, and in the current state of the SassCompiler, it does fire some warnings like the following:

      WARNING: Base-level rule contains the parent-selector-referencing character '&'; the character will be removed:
      .v-sa & .v-button-link:focus {
      	outline-offset: -3px;
      }
      

      These warnings are due to the fact that Vaadin's base theme is included at top level, not within a theme mixin, i.e. all theme style rules are generated like .v-button {...} instead of .admincentral .v-button {...} which would be costly for browser rendering.

      The effective reason why such warnings are fired is related to multiple-theme environments, like in a page that would embed several vaadin portlets with different themes. In our case, it has no use and causes no harm to ignore these warnings. However, we definitely need a way to reduce them to silence.

      This is the vaadin issue we need to push a little bit:

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              mgeljic Mikaël Geljić
              mgeljic Mikaël Geljić
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD