Details
-
Bug
-
Resolution: Won't Do
-
Neutral
-
None
-
5.3, 5.4
-
None
-
None
Description
The usage of WorkflowPublicationActionDefinition is hardcoded in WorkflowFormDialogPresenter (line 93):
WorkflowPublicationActionDefinition commit = new WorkflowPublicationActionDefinition();
As a consequence, there is no clean way for developers to replace this implementation, e.g. for custom functionality.
It's especially confusing since the dialog seems to be partially defined by config:/modules/workflow/dialogs/publish, but action definitions put in there have no effect.
For better modularity, that class should probably be referred to through an interface and an implementation provided either through the dialog definition (in JCR) or a module's configuration file.
Checklists
Acceptance criteria