Uploaded image for project: 'Magnolia Workflow Module'
  1. Magnolia Workflow Module
  2. MGNLWORKFLOW-315

WorkflowPublicationActionDefinition is not replaceable

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Do
    • Neutral
    • None
    • 5.3, 5.4
    • None
    • None

    Description

      The usage of WorkflowPublicationActionDefinition is hardcoded in WorkflowFormDialogPresenter (line 93):

      WorkflowPublicationActionDefinition commit = new WorkflowPublicationActionDefinition();

      As a consequence, there is no clean way for developers to replace this implementation, e.g. for custom functionality.

      It's especially confusing since the dialog seems to be partially defined by config:/modules/workflow/dialogs/publish, but action definitions put in there have no effect.

      For better modularity, that class should probably be referred to through an interface and an implementation provided either through the dialog definition (in JCR) or a module's configuration file.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              creichenbach Cedric Reichenbach
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD