Uploaded image for project: 'Excel Renderer (closed)'
  1. Excel Renderer (closed)
  2. MGNLXLS-8

SaveHandler or ParagraphRenderer

    XMLWordPrintable

Details

    • Task
    • Resolution: Won't Do
    • Major
    • 1.0
    • None
    • None
    • None

    Description

      I couldnt' manage to put the pre-rendering logic in a SaveHandler, mostly because it doesn't have a "postSave" hook. Using the one from the dialog could have worked - if there'd be a clean way to get the "save node".
      Also, this introduced a dependecy on HierarchyManager, which would break 3.0 / 3.1 compatibility since the HierarchyManager changed package. *

      Instead now, the logic is called by the excel.jsp, which is similar but less elegant than having this in a ParagraphRenderer.
      The SaveHandler still exists, but only removes the "pre-rendered" property if it had been previously created.

      Let's review this.

      • since we will also move the NodeData and Content classes to interfaces in the api package, breakage will happen anyway. I guess we'll need to do parallel releases.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              pbaerfuss Philipp Bärfuss
              gjoseph Magnolia International
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Task DoR