Uploaded image for project: 'Magnolia Shop (closed)'
  1. Magnolia Shop (closed)
  2. MSHOP-2

Use standard i18n dialog features instead of "MultiLanguageDialogEdit"

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 1.0
    • None
    • None

    Description

      After installation of the sampleShop the product dialog throws a NullPointerException in a "MultiLanguageDialogEdit" control. This happens (most likely), because no languages were defined. Instead of defining languages in the custom way the control expects it, it would be better to use the standard i18n dialog mechanism!

      Stack trace btw:

      2011-08-06 09:10:55,972 ERROR se.[Catalina].[localhost].[/magnolia444].[default]: Servlet.service() for servlet default threw exception
      java.lang.RuntimeException: java.lang.NullPointerException
      at info.magnolia.module.cache.filter.CacheFilter.doFilter(CacheFilter.java:159)
      at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:60)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      at info.magnolia.cms.i18n.I18nContentSupportFilter.doFilter(I18nContentSupportFilter.java:75)
      at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      at info.magnolia.module.cache.filter.GZipFilter.doFilter(GZipFilter.java:73)
      at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:60)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:84)
      at info.magnolia.cms.security.BaseSecurityFilter.doFilter(BaseSecurityFilter.java:64)
      at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      at info.magnolia.cms.security.LogoutFilter.doFilter(LogoutFilter.java:88)
      at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:60)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      at info.magnolia.cms.security.auth.login.LoginFilter.doFilter(LoginFilter.java:82)
      at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:84)
      at info.magnolia.cms.filters.CosMultipartRequestFilter.doFilter(CosMultipartRequestFilter.java:86)
      at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:60)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      at info.magnolia.cms.filters.ContentTypeFilter.doFilter(ContentTypeFilter.java:102)
      at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      at info.magnolia.cms.filters.ContextFilter.doFilter(ContextFilter.java:120)
      at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      at info.magnolia.cms.filters.CompositeFilter.doFilter(CompositeFilter.java:66)
      at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
      at info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:105)
      at info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:216)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
      at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
      at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:174)
      at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
      at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
      at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
      at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:174)
      at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:874)
      at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665)
      at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528)
      at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81)
      at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:689)
      at java.lang.Thread.run(Thread.java:680)
      Caused by: java.lang.NullPointerException
      at info.magnolia.module.shop.dialog.MultiLanguageDialogEdit.initLanguages(MultiLanguageDialogEdit.java:155)
      at info.magnolia.module.shop.dialog.MultiLanguageDialogEdit.init(MultiLanguageDialogEdit.java:96)
      at info.magnolia.cms.gui.dialog.DialogFactory.getDialogControlInstanceByName(DialogFactory.java:188)
      at info.magnolia.cms.gui.dialog.DialogFactory.loadDialog(DialogFactory.java:94)
      at info.magnolia.cms.gui.dialog.DialogControlImpl.initializeConfig(DialogControlImpl.java:535)
      at info.magnolia.cms.gui.dialog.DialogControlImpl.init(DialogControlImpl.java:157)
      at info.magnolia.cms.gui.dialog.DialogFactory.getDialogControlInstanceByName(DialogFactory.java:188)
      at info.magnolia.cms.gui.dialog.DialogFactory.loadDialog(DialogFactory.java:94)
      at info.magnolia.cms.gui.dialog.DialogControlImpl.initializeConfig(DialogControlImpl.java:535)
      at info.magnolia.cms.gui.dialog.DialogControlImpl.init(DialogControlImpl.java:157)
      at info.magnolia.cms.gui.dialog.DialogFactory.getDialogInstance(DialogFactory.java:100)
      at info.magnolia.module.admininterface.DialogMVCHandler.createDialog(DialogMVCHandler.java:212)
      at info.magnolia.module.data.dialogs.DataDialog.createDialog(DataDialog.java:80)
      at info.magnolia.module.data.dialogs.TypeSelectDataDialog.createDialog(TypeSelectDataDialog.java:141)
      at info.magnolia.module.admininterface.DialogMVCHandler.getDialog(DialogMVCHandler.java:457)
      at info.magnolia.module.admininterface.DialogMVCHandler.renderHtml(DialogMVCHandler.java:417)
      at info.magnolia.cms.servlets.MVCServlet.doPost(MVCServlet.java:124)
      at info.magnolia.cms.servlets.MVCServlet.doGet(MVCServlet.java:69)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
      at info.magnolia.cms.filters.ServletDispatchingFilter.doFilter(ServletDispatchingFilter.java:119)
      at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:84)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:84)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:84)
      at info.magnolia.cms.filters.CompositeFilter.doFilter(CompositeFilter.java:66)
      at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      at info.magnolia.cms.filters.VirtualUriFilter.doFilter(VirtualUriFilter.java:69)
      at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:88)
      at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
      at info.magnolia.module.cache.executor.Bypass.processCacheRequest(Bypass.java:57)
      at info.magnolia.module.cache.filter.CacheFilter.doFilter(CacheFilter.java:147)
      ... 46 more

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              will Will Scheidegger
              will Will Scheidegger
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Checklists

                  Bug DoR
                  Task DoD