-
Improvement
-
Resolution: Unresolved
-
Neutral
-
None
-
2.0.3
-
None
In the class ThemeAwareImageGenerator if the local variable "variation" is null the code simply prints "No image variation found, will return original image." It would be helpful to know what variation was it trying to find. In the context of support someone can give us the feedback --> "I'm seeing this in my log":
2023-07-03 10:36:11 INFO 611724557 [https-jsse-nio-8103-exec-6] [info.magnolia.templating.imaging.ThemeAwareImageGenerator] No image variation found, will return original image.
This really doesn't help as much as it could. I propose the following changes.
- The class ThemeAwareParameter should have a getter for the private member "variationName" since this is the data used to find the variation.
- The class ThemeAwareParameter should have a getter for the private member "themeName" since this data is also used in the process to find the variation.
- The class ThemeAwareImageGenerator should report the theme and variation name which was used. Something like:
Image variation [variationName] not found in theme [themeName] , will return original image.
Notes
Once the user knows both the theme and variation name they can search their FTL (template script) for the reported variation name (i.e. find where it's being requested) and then check their theme configuration. It's possible:
- The theme configuration has changed.
- There is a typo in the template script.
- They aren't applying the correct theme to the site.
- is related to
-
MTE-153 Supplied variation [null] could not be found
- Open