Uploaded image for project: 'Magnolia Multisite Module'
  1. Magnolia Multisite Module
  2. MULTISITE-28

By usage of smartphone variation, all links are created as external links, in sites with no domain configured

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Neutral
    • Resolution: Fixed
    • Affects Version/s: 1.0.6, 1.1
    • Fix Version/s: 1.0.7, 1.1.2
    • Labels:
    • Magnolia Release:
      5.2.9, 5.3.4

      Description

      As for M5 the mutisite module is the successor of the ETK module, I created this issue.
      It is a "clone" of MGNLETK-111.

      Same content/description is valid:
      "If you are using a variation on site definition like the smartphone variation, all links on the smartphone view are rendered as external (complete with host) links.

      The reason for this bug is, that the SiteMergeFilter creates site proxies, if a variation is used. The equals comparison in the CompoundLinkTransformer fails on usage with site proxies. And so the link transformer creates external link for links in same site, too.
      (Specifically isTargetExternal returns true, so 'result = linkManager.getCompleteUrl().transform(link);' is the result.)

      To reproduce this issue create a new home page and view the source code of the smartphone preview iframe."

      Note that this is only only occurs with pages in sites that have no domain configured, such as the stock default site.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pmundt Philip Mundt
              Reporter:
              cringele Christian Ringele
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Date of First Response: