Uploaded image for project: 'Magnolia Multisite Module'
  1. Magnolia Multisite Module
  2. MULTISITE-59

Use injection instead of Components.getComponent() where possible/useful

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 1.2.3
    • None
    • None
    • Basel 28
    • 2

      There are quite a few classes that still make heavy use of Components.getComponent() in the module where we should instead use injection and IoC.

      The following classes can be adjusted:

      • info.magnolia.multisite.CrossSiteAbsolutePathTransformer and info.magnolia.multisite.DomainNamePathTransformer
        • info.magnolia.cms.beans.config.ServerConfiguration and
        • info.magnolia.cms.beans.config.URI2RepositoryManager should be injected
      • info.magnolia.multisite.MultiSiteURI2RepositoryManager
        • info.magnolia.module.site.SiteManager and
        • javax.inject.Provider<info.magnolia.cms.core.AggregationState> should be injected
      • info.magnolia.multisite.MultiSiteRootVirtualURIMapping
        • info.magnolia.module.site.functions.SiteFunctions should be injected

        Acceptance criteria

              pmundt Philip Mundt
              pmundt Philip Mundt
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Task DoD

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0d
                    0d
                    Logged:
                    Time Spent - 1.5h
                    1.5h