Uploaded image for project: 'Magnolia Multisite Module'
  1. Magnolia Multisite Module
  2. MULTISITE-69

MultisteFilter cleanURI is not taking into account all possible cases for site roots

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 1.2.5
    • 1.2
    • None
    • Kromeriz 74
    • 3

      Multisite filter checks in clearURI method for homepage by comparing uri to /siteName.html. If uri matches the /siteName.html, handle in aggregation state is then set to /. However that is not the only case for resolving the homepage, we should cover other cases and set / handle for them as well:

      • /siteName
      • /siteName/
      • /siteName~my=awesome~selector~.html
      • /siteName~my=awesome~selector~

      Check for /siteName.html is not sufficient. We might consider to add rule for matching the /siteName.html or /siteName~my=awesome~selector~.html that users can activate for SEO purposes (prevent duplicate content).

      We also need to improve checks in info.magnolia.multisite.sites.matchers.NotEmptyHandleMatcher. Current behavior is erroneous because we only check for startsWith handlePrefix, thus pages like /travel, /travel0, /travelSomething matches the handlePrefix.

        Acceptance criteria

              jsimak Jaroslav Simak
              jsimak Jaroslav Simak
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Bug DoR
                  Task DoD

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0d
                    0d
                    Logged:
                    Time Spent - 0.5h
                    0.5h