Uploaded image for project: 'Magnolia pages module'
  1. Magnolia pages module
  2. PAGES-1401

Enable developer to control if greenbars are rendered inside or outside the template HTML

    XMLWordPrintable

Details

    • Story
    • Resolution: Unresolved
    • Neutral
    • None
    • None
    • None
    • None

    Description

       Generally, editbars are added above whatever html the component renders. But when the component renders a single parent element, and that element is a div, then the editbars are rendered inside that parent div. (Update: probably this is the case not only with "div" but any block level html element.)

      We should likely document the current behaviour.

      It does seem important for developers to put the bars in one place or the other - so we could maybe add some kind of property to control this - either in the HTML of the template - or maybe a setting on the template definition."render-bars-inside" "render-bars-outside".

      For context also see this input where a customer does not like the bars being rendered inside: 
      https://magnolia.productboard.com/insights/notes/view/1323-notes-assigned-to-me/notes/34682454

       

      Any change should be made carefully as we must ensure to be backwards compatible as customers may be relying on this behaviour now.


       

       

      Checklists

        Acceptance criteria

        Attachments

          1.
          Implementation Sub-task To Do Unassigned
          2.
          Review Sub-task To Do Unassigned
          3.
          Pre-Integration QA Sub-task To Do Unassigned
          4.
          QA Sub-task To Do Unassigned

          Activity

            People

              Unassigned Unassigned
              czimmermann Christopher Zimmermann
              DeveloperX
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Checklists

                  Task DoD