Uploaded image for project: 'Magnolia UI'
  1. Magnolia UI
  2. MGNLUI-5415

Break ChainedAction execution sequence on failure gracefully

    XMLWordPrintable

Details

    • Task
    • Resolution: Won't Fix
    • Neutral
    • None
    • 6.2
    • None

    Description

      TheĀ info.magnolia.ui.contentapp.action.ChainedAction#ChainedAction currently keeps executing actions irrespective of whether there is a failure (validation) in an Action.

      In order to prevent further validation checks on dependent actions, failing actions have two choices - either duplicate validation logic or throw an Exception.

      Throwing Exception propagates all the way to the parent UI as RpcInvocationException for a very simple thing such as form validation failure. In order to avoid this behavior, the action sequence has to duplicate this validation in subsequent actions, which has it's own side effects of code duplication and suboptimal performance due to dependent ActionDefinition objects created and executed each time the chain sequence is executed.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                rdhar Rishab Dhar
                rdhar Rishab Dhar
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoR

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Time Spent - 22m Remaining Estimate - 5h
                      5h
                      Logged:
                      Time Spent - 22m Remaining Estimate - 5h
                      22m