Uploaded image for project: 'Magnolia pages module'
  1. Magnolia pages module
  2. PAGES-323

Missing Constructor at ConfiguredSpaRenderableDefinition

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 6.2.3
    • None
    • None
    • None

      The ConfiguredSpaRenderableDefinition is extending the
      ConfiguredTemplateDefinition but does not have a suitable constructor, which injects the
      TemplateAvailability.

      Check ConfiguredSpaRenderableDefinition java class at git.

      The TemplateAvailability is needed to manage the template availability. The
      ConfiguredSiteTemplateAvailability does not work correctly.

      Steps to reproduce :

      1. Install the SPA demo
      2. Once Magnolia is running (for react) try to add the templateAvailability
      3. /magnolia/light-modules/react-minimal-lm/templates/pages/basic.yaml
        Add property "templateType: home"
        To /magnolia/light-modules/react-minimal-lm/templates/pages/contact.yaml
        Add property "templateType: content"

      Workaround:

      Add the constructor to the ConfiguredSpaRenderableDefinition class:

      /**
       * This file Copyright (c) 2019 Magnolia International
       * Ltd.  (http://www.magnolia-cms.com). All rights reserved.
       *
       *
       * This file is dual-licensed under both the Magnolia
       * Network Agreement and the GNU General Public License.
       * You may elect to use one or the other of these licenses.
       *
       * This file is distributed in the hope that it will be
       * useful, but AS-IS and WITHOUT ANY WARRANTY; without even the
       * implied warranty of MERCHANTABILITY or FITNESS FOR A
       * PARTICULAR PURPOSE, TITLE, or NONINFRINGEMENT.
       * Redistribution, except as permitted by whichever of the GPL
       * or MNA you select, is prohibited.
       *
       * 1. For the GPL license (GPL), you can redistribute and/or
       * modify this file under the terms of the GNU General
       * Public License, Version 3, as published by the Free Software
       * Foundation.  You should have received a copy of the GNU
       * General Public License, Version 3 along with this program;
       * if not, write to the Free Software Foundation, Inc., 51
       * Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
       *
       * 2. For the Magnolia Network Agreement (MNA), this file
       * and the accompanying materials are made available under the
       * terms of the MNA which accompanies this distribution, and
       * is available at http://www.magnolia-cms.com/mna.html
       *
       * Any modifications to this file must keep this entire header
       * intact.
       *
       */
      package info.magnolia.rendering.spa.renderer;
      
      import info.magnolia.rendering.template.configured.ConfiguredTemplateDefinition;
      
      import java.util.List;
      
      import lombok.Getter;
      import lombok.Setter;
      import lombok.ToString;
      
      /**
       * Default implmentation for {@linkplain SpaRenderableDefinition}.
       */
      @Getter
      @Setter
      @ToString
      public class ConfiguredSpaRenderableDefinition extends ConfiguredTemplateDefinition implements SpaRenderableDefinition {
          private List<String> jsPaths;
          private List<String> cssPaths;
      
       @Inject
          public ConfiguredSpaRenderableDefinition(TemplateAvailability templateAvailability) {
              super(templateAvailability);
              
          }
      }
      

        Acceptance criteria

              canh.nguyen Canh Nguyen
              canh.nguyen Canh Nguyen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Bug DoR
                  Task DoD