Uploaded image for project: 'Magnolia pages module'
  1. Magnolia pages module
  2. PAGES-387

Components Are Still Editable When Editable Property Is False

    XMLWordPrintable

Details

    Description

      Verify:

      Steps to reproduce

      • You can see this in the demo by editing:

      travel-demo/templates/pages/home.yaml

      • Set the footer to editable : false (it might be false already)
      • Check the travel/tour-type page 
      • Scroll down to the footer, click on "About Magnolia Travels"

      Expected results

      You cannot edit the footer even if you click on the component

      Actual results

      You can see the edit actions on the actionbar and making changes will persist throughout other templates.

      Development notes

      I tried adding editable: false in other definitions such as /travel-demo/templates/pages/prototype.yaml just in case and it just seems like the green boxes around the component do not get highlighted, but the action bar on the right still shows actions. You can then edit the component and the change will be seen on other pages using the same footer.

      I attached 2 screenshots, the first is showing how it looks when editable is true and the second when it is false. Notice that both still show the actions and are editable but the one enabled has the green boxes instead.

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                lam.nguyen Lam Nguyen Bao
                jnodarse Julian Nodarse
                Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Bug DoR
                    Task DoD