Uploaded image for project: 'Magnolia pages module'
  1. Magnolia pages module
  2. PAGES-514

Drop "class" prop for "renderType: spa"

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Won't Do
    • Neutral
    • None
    • None
    • None
    • None

    Description

      Currently for renderType: spa Page template def must have class prop.

      title: SPA Page
      dialog: spa-light-module:pages/default
      templateScript: /spa-light-module/webresources/index.html
      renderType: spa
      class: info.magnolia.rendering.spa.renderer.SpaRenderableDefinition
      areas:
        (...)
      

      Could we drop the need for class prop, since we already have spa as renderType?

      To have something like:

      title: SPA Page
      dialog: spa-light-module:pages/default
      templateScript: /spa-light-module/webresources/index.html
      renderType: spa
      areas:
        (...)
      

      It looks less scary and more dev friendly

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                bstaryga Bartosz Staryga
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoD