Uploaded image for project: 'Magnolia pages module'
  1. Magnolia pages module
  2. PAGES-539

Ignore postMessages which do not specify a page editor action

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Neutral Neutral
    • 6.2.13
    • None
    • None
    • None
    • HL & LD 41
    • 1

      Some frameworks or even browser extensions can produce postMessages which break our server-side postMessage handler.

      Sanitize by checking if the postMessage object contains action property with a proper action type set.

       

      Symptoms:

      Problem occurs when using Angular project with angular-editor 1.2.0-beta, doing external SPA (with baseURL and routeTemplate) on FIrefox (not reproducable on Chrome)

      Upon saving a change to a component in page editor - browser console shows exception:

      com.google.gwt.logging.client.LogConfiguration
SEVERE: (TypeError) : ji2.uncheckedCast(...).charCodeAt is not a function
com.google.gwt.core.client.JavaScriptException: (TypeError) : ji2.uncheckedCast(...).charCodeAt is not a function
	at Unknown.split_2(http://localhost:8080/VAADIN/widgetsets/info.magnolia.PageEditor/info.magnolia.PageEditor.nocache.js)
	at Unknown.decode(http://localhost:8080/VAADIN/widgetsets/info.magnolia.PageEditor/info.magnolia.PageEditor.nocache.js)
	at Unknown.handleMessage(http://localhost:8080/VAADIN/widgetsets/info.magnolia.PageEditor/info.magnolia.PageEditor.nocache.js)
	at Unknown.$addMessageHandler/receiver<(http://localhost:8080/VAADIN/widgetsets/info.magnolia.PageEditor/info.magnolia.PageEditor.nocache.js)
	at Unknown.apply_0(http://localhost:8080/VAADIN/widgetsets/info.magnolia.PageEditor/info.magnolia.PageEditor.nocache.js)
	at Unknown.entry0(http://localhost:8080/VAADIN/widgetsets/info.magnolia.PageEditor/info.magnolia.PageEditor.nocache.js)
	at Unknown.entry_0/<(http://localhost:8080/VAADIN/widgetsets/info.magnolia.PageEditor/info.magnolia.PageEditor.nocache.js)
	at Unknown.invokeTask(http://localhost:4200/polyfills.js)
	at Unknown.runTask(http://localhost:4200/polyfills.js)
	at Unknown.invokeTask(http://localhost:4200/polyfills.js)
	at Unknown.invokeTask(http://localhost:4200/polyfills.js)
	at Unknown.globalZoneAwareCallback(http://localhost:4200/polyfills.js)
	at Unknown.handleEvent*customScheduleGlobal(http://localhost:4200/polyfills.js)
	at Unknown.scheduleTask(http://localhost:4200/polyfills.js)

       

        Acceptance criteria

              rsiska Robert Šiška
              rsiska Robert Šiška
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Task DoD

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0d
                    0d
                    Logged:
                    Time Spent - 3.5h
                    3.5h