Uploaded image for project: 'Magnolia pages module'
  1. Magnolia pages module
  2. PAGES-579

SPA: Support templating in baseUrl

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Critical
    • 6.3.0
    • None
    • None
    • None

    Description

      Context:

      This is blocking editors from being able to edit websites. Now developers haave to do the edits since they have the SPA running locally.

       

      Shared by Josh Beckerleg from D&G: 

      *Full video with problem statement: https://www.loom.com/share/4dd747889c1d4fa2929fe4e742e02268*

      My node has these properties

      @path: "/dgx-beko-registration/appliance-details"
      domain: "beko.partners.dandg.uk.euw1.test.test.athome.domgentest.cloud"
      applicationPath: "/register"

      Im trying to load up the test site for this page in magnolia editor.
       
      In the page template definition. This works:

      baseUrl: https://beko.partners.dandg.uk.euw1.test.test.athome.domgentest.cloud
      routeTemplate: /register/appliance-details 

      But this does NOT: 

      baseUrl: https://
      routeTemplate: beko.partners.dandg.uk.euw1.test.test.athome.domgentest.cloud/register/appliance-details

      Im asking because we are trying to do this. Which is giving us the double magnolia thing.

      baseUrl: https://
      routeTemplate: "{{domain}}{{applicationPath}}/appliance-details" 

      Ive been digging around. Here:
      https://git.magnolia-cms.com/projects/MODULES/repos/pages/browse/magnolia-spa-rendering[…]java/info/magnolia/pages/spa/routing/DefaultSpaRouter.java
      Guessing that the PATTERN property strips everything that isnt in that regexp? So the '.' characters are dropping in the routetemplate?
       
      Is it possible to extend the replacer logic to the baseUrl as well? That way I can get the full value in without it being stripped by the path regexp?

      Checklists

        Acceptance criteria

        Attachments

          Issue Links

            Activity

              People

                canh.nguyen Canh Nguyen
                mrajkovic Matt Rajkovic
                DeveloperX
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Checklists

                    Task DoD

                    Time Tracking

                      Estimated:
                      Original Estimate - Not Specified
                      Not Specified
                      Remaining:
                      Remaining Estimate - Not Specified
                      Not Specified
                      Logged:
                      Time Spent - 1.5d
                      1.5d