Uploaded image for project: 'Magnolia pages module'
  1. Magnolia pages module
  2. PAGES-89

Consolidate display of edit-bars for inherited elements

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Neutral Neutral
    • None
    • None
    • None
    • None

      The display of inherited areas and components have changed due to various unrelated changes in the page-editor.
      IIRC inherited areas and components were always shown in the page-structure but annotated with 'inherited' on edit-bars and their actions were disabled.
      Looking at the code this changed in MAGNOLIA-5439: Now all of a sudden inherited areas are wiped from the structure, but leaving the components in, which causes several side-effects, e.g. components associated with the parent-page instead of an area and different display for inherited areas vs inherited components.
      This ended up crashing when PAGES-62 was introduced and blindly casting the parent of all components to MgnlArea. This was patched in a QA commit, which now consistently removes all inherited elements, but breaking the initial idea of still displaying those.

      Some more notes:

      • the 'inherited' annotation was former criticized for not being i18nable.. so maybe rather have some sort of icon for display.
      • Do we actually need to display the inherited ones? adding more noise to the page.

        Acceptance criteria

              Unassigned Unassigned
              ejervidalo Espen Jervidalo
              AuthorX
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:

                  Task DoD