Uploaded image for project: 'Magnolia pages module'
  1. Magnolia pages module
  2. PAGES-989

Remove UniqueNameGenerator from Pages codebase and use the one from Norsu project

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Neutral
    • None
    • None
    • None
    • None

    Description

      As we needed the unique name generating logic at two places in Norsu project, we moved implementation of the util from Pages project to Norsu.

      https://git.magnolia-cms.com/projects/MODULES/repos/pages/browse/magnolia-pages-norsu-app/src/main/java/info/magnolia/pages/norsu/app/util/UniqueNameGenerator.java?at=refs%2Fheads%2Ffeature%2FpagesVersion-6.3-norsu-SNAPSHOT

      https://git.magnolia-cms.com/projects/CLOUD/repos/norsu/pull-requests/299/commits/b5ab1d631dfe949924fa9f9a7ac0c77f400b2ab9#ui-framework-integration/src/main/java/info/magnolia/norsu/ui/util/UniqueNameGenerator.java

      So please remove the original one from Pages project and use the Norsu one.
      Additionaly the logic was slightly updated to be in par with current behaviour, i.e. if the baseName node is not in place, we use the name without prefix instead of adding 0 prefix always.

      E.g.
      baseName, baseName0, baseName1, ...
      instead of
      baseName0, baseName1, baseName2, ...

      If this would cause troubles with current implementation/usages please inform us to change the behaviour back..

      Checklists

        Acceptance criteria

        Attachments

          1.
          Implementation Sub-task To Do Unassigned
          2.
          Review Sub-task To Do Unassigned
          3.
          Pre-Integration QA Sub-task To Do Unassigned
          4.
          QA Sub-task To Do Unassigned

          Activity

            People

              Unassigned Unassigned
              asiska Adam Siska
              AuthorX
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Checklists

                  Bug DoR
                  Task DoD