Details
-
Improvement
-
Resolution: Done
-
Medium
-
None
-
None
-
-
Empty show more show less
-
Yes
-
Nucleus 33, Nucleus 34
-
2
-
Yes
Description
A pull request for this issue has been created at https://git.magnolia-cms.com/projects/MODULES/repos/publishing/pull-requests/114/overview
Â
info.magnolia.publishing.sender.http.HttpClientProvider was recently added to the code base. It is used to create an Apache HttpClient for the respective ReceiverDefinition.
While this is a welcomed addition, it is not configurable, since it is privately instantiated in info.magnolia.publishing.sender.AbstractSender
Â
We have several public instances, which require different proxy settings on the HttpClient.
Â
Previously, we extended HttpCommitOperation and HttpRollbackOperation (which get instantiated by the Sender), while this is still somewhat possible, the public visible constructors are now Deprecated - effectively rendering our solution a dead end.
Â
Please make the HttpClientProvider properly injectable - this would allow us to override the component.
Fixing this issue globally in the Sender seems to be the most reasonable and universally applicable approach.
Checklists
Attachments
1.
|
Implementation |
|
Completed | Daniel Alonso |
2.
|
PiQA |
|
Completed | Adam Siska |
3.
|
QA |
|
Completed | Quach Hao Thien |
4.
|
Backport 6.2 Impl |
|
Completed | Daniel Alonso |
5.
|
PiQA 6.2 |
|
Completed | Adam Siska |
6.
|
Code review |
|
Completed | Adam Siska |
7.
|
Update publishing artifact dependency on CE |
|
Completed | Daniel Alonso |