Uploaded image for project: 'Publishing'
  1. Publishing
  2. PUBLISHING-193

Allow HttpClientProvider to be injected

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Medium Medium
    • 1.4.0, 1.3.9
    • None
    • None
    • Yes
    • Nucleus 33, Nucleus 34
    • 2
    • Yes

      A pull request for this issue has been created at https://git.magnolia-cms.com/projects/MODULES/repos/publishing/pull-requests/114/overview

       
      info.magnolia.publishing.sender.http.HttpClientProvider was recently added to the code base. It is used to create an Apache HttpClient for the respective ReceiverDefinition.

      While this is a welcomed addition, it is not configurable, since it is privately instantiated in info.magnolia.publishing.sender.AbstractSender
       
      We have several public instances, which require different proxy settings on the HttpClient.
       
      Previously, we extended HttpCommitOperation and HttpRollbackOperation (which get instantiated by the Sender), while this is still somewhat possible, the public visible constructors are now Deprecated - effectively rendering our solution a dead end.
       
      Please make the HttpClientProvider properly injectable - this would allow us to override the component.

      Fixing this issue globally in the Sender seems to be the most reasonable and universally applicable approach.

        Acceptance criteria

              dalonso Daniel Alonso
              pgaschuetz Philipp Gaschuetz
              Nucleus
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved:
                Work Started:

                  Task DoD

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - Not Specified
                    Not Specified
                    Logged:
                    Time Spent - 7.5h
                    7.5h