Uploaded image for project: 'DAM Focal'
  1. DAM Focal
  2. RESPDAM-83

JCR default values for variations

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Medium Medium
    • 2.4.1
    • None
    • None
    • None

      info.magnolia.dam.focal.point.observation.FocalPointAssetObservation writes default values (50, 50) for each registered variation into the JCR when a new asset is created.

      Generally, I would like to question, whether this approach is the correct way to tackle default values, as it doesn't account for variations added to the definitions after an asset was created.
      Without going into depth, FocalPointAdapter seems to be a more suitable location to add default/fallback values on the fly ensuring that consumers always get a focal point value for each registered variation.

      Disregarding the usefulness of writing default values to the JCR in general:

      • we have 8 variations registered
      • we have 2500+ PDFs stored in the DAM (and growing)
      • FocalPointAssetObservation writes default values irrespectively of the underlying mimeType
      • in our scenario, this leads to the creation of 22.500+  unnecessary nodes being created

      If persisting default values is really necessary, kindly consider adding a condition based on the mimeType/fileType/tika recognized mimeType.

      Many thanks!

        Acceptance criteria

              rfalvo Raphael Falvo
              pgaschuetz Philipp Gaschuetz
              Services
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved:
                Work Started:

                  Bug DoR
                  Task DoD