Uploaded image for project: 'Task Management'
  1. Task Management
  2. TASKMGMT-49

Make Newer Constructor In TaskListPresenter Public

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Neutral
    • None
    • None
    • None

    Description

      The new constructor in TaskListPresenter is not public: https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/tasks-app/src/main/java/info/magnolia/task/app/TaskListPresenter.java#66

      There is a comment saying

          /**
           * @deprecated since 6.2.6, use {@link #TaskListPresenter(GridViewDefinition, ComponentProvider, AvailabilityChecker, TasksManager, TasksDataSourceDefinition, Datasource, TaskDataSourceObservation, Provider, PropertySetFactory)}.
           */
      

      But it is not possible since it is not public.

      The constructor in TasksDataProvider calls the new constructor via fetch().

      The confusion is with the comment saying to use the new TaskListPresenter constructor. The constructor should be Public, or the comment should be removed.

      Checklists

        Acceptance criteria

        Attachments

          Activity

            People

              Unassigned Unassigned
              jnodarse Julian Nodarse
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Checklists

                  Task DoD