-
Bug
-
Resolution: Fixed
-
Neutral
-
1.2.8, 1.2.9
-
None
Steps to reproduce
- Login to superuser and publish a page, set the publication date in the future (maybe tomorrow) to trigger scheduled pending publication
- Â Still in the session, open the task, click on "assign to me", then "approve and publish"
- This will create a scheduled task and wait for its publication. Left it there and switch to editor account
- Login to editor account such as demo "eric" one to see the issue
Expected results
- Because the scheduled to be published task has no relation to "eric" editor, he should see no tasks in his pending list as well as total task count
Actual results
Workaround
- No
Development notes
- Investigation shown that the query in info.magnolia.task.persistence.TasksStoreImpl.findTasksByAssigneeAndStatus(String, List<Status>) is not correct.
- Let's take "eric" editor as an example, we have below query:
SELECT * FROM [mgnl:task] WHERE (actorId = 'eric' OR actorIds = 'eric') AND status LIKE '%InProgress%' OR status LIKE '%Scheduled%'
- The query list out "Scheduled" tasks that not belong to the editor
- The fix could be:
SELECT * FROM [mgnl:task] WHERE (actorId = 'eric' OR actorIds = 'eric') AND (status LIKE '%InProgress%' OR status LIKE '%Scheduled%')
Discovery
- The issue is reproduce-able (check the screen recording in attachment)Â and the proposed solution above seems legit too.
Acceptance criteria
- is duplicated by
-
MGNLUI-6917 Users are notified on tasks not belonging to them
- Closed
- is related to
-
MGNLUI-6341 Notifications show in wrong tabs and the count is wrong
- Closed
1.
|
Implementation | Completed | Nguyen Phung Chi | |
2.
|
Review | Completed | Evzen Fochr | |
3.
|
PiQA | Completed | Unassigned | |
4.
|
Final QA | Completed | Nguyen Phung Chi |