Details
-
Improvement
-
Resolution: Outdated
-
Neutral
-
None
-
None
-
None
Description
Situtation:
Currently, we have 2 different methods in TextClassificationService to run classification for 2 scenarios:
- A single String as parameter, this is using for ecommerce integration
- Collection<String> as parameter, mainly use for Text classification modules, running classification on Pages.
public interface TextClassificationService { CompletableFuture<Collection<TextLabel>> submitTextClassificationRequest(String text); CompletableFuture<Map<String, Collection<TextLabel>>> submitTextClassificationRequest(Collection<String> texts); //... }
AC:
- Find a way to unify those 2 methods if possible
- Refactor the service and flow to have the best code readability (for maintenance and further improvement)
Checklists
Acceptance criteria