[ABTEST-539] VariantJcrDataProvider relies on implementation of JcrDataProvider#size Created: 25/Jan/23  Updated: 01/Feb/23

Status: Open
Project: A/B Testing
Component/s: None
Affects Version/s: 1.0.1
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Roman Kovařík Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File ABTestVariantActionsUITest_addAndDeleteTestVariant.mp4    
Issue Links:
dependency
is depended upon by MGNLUI-7764 JcrDataProvider#sizeInBackEnd doesn't... Open
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Epic Link: AuthorX Maintenance
Team: AuthorX

 Description   

Steps to reproduce

  1.  Revert https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/pull-requests/2287/overview
  2.  Go to https://nightly.magnolia-cms.com/.magnolia/admincentral#app:abn-testing:detail;/:add
  3. Switch to the Variants tab

Expected results

I can still work with the UI

Actual results

Infinite loading bar, browser tab not responsive.

Workaround

Open new browser tab to unlock the UI, the Variants tab still can't be used though.

Development notes

We can see in https://git.magnolia-cms.com/projects/ADDON/repos/ab-testing/browse/magnolia-abtesting-ui/src/main/java/info/magnolia/abtesting/app/dataprovider/VariantJcrDataProvider.java#60 that it overrides #fetch but not #size, relying of the fact the #fetch is called to compute super#size.

Suggested solution: Implement #size instead of relying on certain super impl.


Generated at Sun Feb 11 22:57:14 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.