[ADMINCTR-236] Cannot label app group in YAML Created: 02/Sep/22  Updated: 05/Sep/22  Resolved: 05/Sep/22

Status: Closed
Project: Admincentral
Component/s: None
Affects Version/s: 6.2.22
Fix Version/s: 6.3.0, 6.2.23

Type: Bug Priority: Neutral
Reporter: Chris Jennings Assignee: Jesus Alonso
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: PNG File image-2022-09-05-10-10-39-745.png    
Issue Links:
Relates
Sub-Tasks:
Key
Summary
Type
Status
Assignee
ADMINCTR-238 DOC: Add label property to the modern... Documentation Task Completed Adrian Brooks  
Template:
Acceptance criteria:
Empty
Documentation update required:
Yes
Date of First Response:
Epic Link: AuthorX Support
Sprint: AuthX 17
Story Points: 0.5
Team: AuthorX

 Description   

Steps to reproduce

  • In the config YAML, add a `label` property to an app group. ie
    groups: 
      - name: content
        label: MY CONTENT GROUP
        apps: 
          - pages-app
          - dam
          #etc.
    
  • Open admin central

Expected results

  • As apps, dialogs, fields, actions, etc. can all be labelled directly in YAML using the `label` property, it might be reasonable to expect the group label to show "MY CONTENT GROUP".

Actual results

  • The property has no effect (as confirmed by Definitions app) and the group is labelled "app-launcher.content.label".

Workaround

  • App groups can only be labelled via a message bundle.


 Comments   
Comment by Jesus Alonso [ 05/Sep/22 ]

Added support for setting label property in groups

Comment by Roman Kovařík [ 05/Sep/22 ]

No support for i18n? https://git.magnolia-cms.com/projects/MODULES/repos/admincentral/commits/d0632ddcded1e54bf1042b6260a1b5a76d1fe78e#magnolia-admincentral/src/main/java/info/magnolia/admincentral/layout/DefaultGroupDefinition.java

Comment by Jesus Alonso [ 05/Sep/22 ]

This should be done in ConfiguredAppLauncherGroupDefinition which is created in https://git.magnolia-cms.com/projects/MODULES/repos/admincentral/commits/d0632ddcded1e54bf1042b6260a1b5a76d1fe78e#magnolia-admincentral/src/main/java/info/magnolia/admincentral/DefaultAppLauncherLayoutManager.java

Comment by Roman Kovařík [ 05/Sep/22 ]

Are you sure? Don't we miss @I18Text annotation? Sorry to bring it up here, I haven't found any associated PR.

Comment by Jesus Alonso [ 05/Sep/22 ]

Thanks for pointing it out. It works fine because AppLauncherGroupDefinition is annotated with @I18Text. (And ConfiguredAppLauncherGroupDefinition implements AppLauncherGroupDefinition).

Generated at Sun Feb 11 23:05:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.