[ADMINCTR-236] Cannot label app group in YAML Created: 02/Sep/22 Updated: 05/Sep/22 Resolved: 05/Sep/22 |
|
| Status: | Closed |
| Project: | Admincentral |
| Component/s: | None |
| Affects Version/s: | 6.2.22 |
| Fix Version/s: | 6.3.0, 6.2.23 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Chris Jennings | Assignee: | Jesus Alonso |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Attachments: |
|
||||||||||
| Issue Links: |
|
||||||||||
| Sub-Tasks: |
|
||||||||||
| Template: | |||||||||||
| Acceptance criteria: |
Empty
|
||||||||||
| Documentation update required: |
Yes
|
||||||||||
| Date of First Response: | |||||||||||
| Epic Link: | AuthorX Support | ||||||||||
| Sprint: | AuthX 17 | ||||||||||
| Story Points: | 0.5 | ||||||||||
| Team: | |||||||||||
| Description |
| Comments |
| Comment by Jesus Alonso [ 05/Sep/22 ] |
|
Added support for setting label property in groups
|
| Comment by Roman Kovařík [ 05/Sep/22 ] |
| Comment by Jesus Alonso [ 05/Sep/22 ] |
|
This should be done in ConfiguredAppLauncherGroupDefinition which is created in https://git.magnolia-cms.com/projects/MODULES/repos/admincentral/commits/d0632ddcded1e54bf1042b6260a1b5a76d1fe78e#magnolia-admincentral/src/main/java/info/magnolia/admincentral/DefaultAppLauncherLayoutManager.java |
| Comment by Roman Kovařík [ 05/Sep/22 ] |
|
Are you sure? Don't we miss @I18Text annotation? Sorry to bring it up here, I haven't found any associated PR. |
| Comment by Jesus Alonso [ 05/Sep/22 ] |
|
Thanks for pointing it out. It works fine because AppLauncherGroupDefinition is annotated with @I18Text. (And ConfiguredAppLauncherGroupDefinition implements AppLauncherGroupDefinition). |