[ADMINCTR-285] Display a global banner ahead of planned downtime Created: 05/Oct/22 Updated: 16/Feb/23 |
|
| Status: | Open |
| Project: | Admincentral |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Neutral |
| Reporter: | Mikaël Geljić | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: | |||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||
| Epic Link: | SSO maintenance | ||||||||||||||||||||||||
| Team: | |||||||||||||||||||||||||
| Description |
|
Quoting from cchard at
Mainly we shouldn't be using the messages app to send such announcements, because messages are not compatible with external users (see comment). |
| Comments |
| Comment by Roman Kovařík [ 05/Oct/22 ] |
|
The admincentral component was extracted into https://jira.magnolia-cms.com/projects/ADMINCTR, should we move the ticket? Edit: there seems to be a fix for the original problem described in a comment below so the ticket might stay in UI project. miruela Should we score this/ relink the support ticket or is the support ticket closed? |
| Comment by Roman Kovařík [ 05/Oct/22 ] |
|
I've checked the problem and as pointed out, we can't get all users for external system here https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/magnolia-ui-framework-jcr/src/main/java/info/magnolia/ui/framework/message/MessagesManagerImpl.java#85, but we can fallback to all logged in users like this ~:
users = listeners.keySet().stream()
.map(userManager::getUser)
.collect(Collectors.toSet());
as we have a map of listeners per all logged in user. |
| Comment by Mikaël Geljić [ 06/Oct/22 ] |
|
Sounds like a good addition on the one hand—thank you all for the suggestion and pointer!—On the other hand, users logging in after the message is sent will not see anything, right? I'll move that story to ADMINCTR anyhow (old habits), then we see how/where we can address it best. |